change object to read pickupStoreInfo #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatrizmaselli
requested review from
hellofanny,
icazevedo and
eduardoformiga
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
lschlee
reviewed
Dec 12, 2023
jeffersontuc
approved these changes
Dec 12, 2023
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
The Pickup Point information is masked when the client is not logged in but the pickUp info is not PII and should not be hidden even when the client is not logged In.
What problem is this solving?
Unmask the pickUp Info
How should this be manually tested?
Call
https://shop.mazda.nl/api/checkout/pub/orders/order-group/1382910500222shippingData.address -> Masked
logisticsInfo.pickupStoreInfo.address -> Unmasked
Beta version:
[email protected]Screenshots or example usage
AFTER
Types of changes